Fixes #16484: rl integration tests v1 #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpoblon
force-pushed
the
userstory_16484/rl_integration_tests_v1
branch
from
3a56a21
to
6dad21c
Compare
peckpeck
reviewed
Jan 17, 2020
| #[test_case("s_basic")] | ||
| #[test_case("s_does_not_exist")] // should fail | ||
| fn real_files(filename: &str) { | ||
| test_real_file(filename); |
There was a problem hiding this comment.
why not put the content of the function directly here ?
peckpeck
approved these changes
Jan 17, 2020
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
userstory_16484/rl_integration_tests_v1
branch
from
6dad21c
to
23fb51f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterative and early work on integration tests for rudder-lang + some structural changes to sources for better naming clarity and to allow for library function calls from integration tests_.
WIP, current notes:
For now, only compile tests are integrated.
3 tests:
For the last two tests, a file is created in the tmp/ folder, and called from the base crate compile function.
TODO:
Test Rules:
Tests supposed to fail (ie the compilation handles a failure properly) are meant to be prefixed with a
f_. If test is supposed to succeed, prefix it with as_. Any file that does not match this criteria shall be ignored.To add a test create a file or add an entry in either the static array or the toml file.
https://issues.rudder.io/issues/16484