Fixes #16593: rl replace file headers to shorter spdx license identifier #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpoblon
force-pushed
the
arch_16593/rl_replace_file_headers_to_shorter_spdx_license_identifier
branch
from
1953557
to
e617c03
Compare
amousset
reviewed
Jan 22, 2020
added 2 commits
January 23, 2020 11:16
…aders_to_shorter_spdx_license_identifier
amousset
reviewed
Jan 23, 2020
amousset
reviewed
Jan 23, 2020
|
Looks good to me. |
amousset
requested changes
Jan 23, 2020
There was a problem hiding this comment.
We are missing the GPLv3 copy in the standard path for spdx (see https://reuse.software/tutorial/ for example).
You can take it from https://github.com/spdx/license-list-data/blob/master/text/GPL-3.0-or-later.txt
amousset
approved these changes
Jan 23, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16593