Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16692: Authorized networks are actually called allowed networks #2761

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Fixes #16692: Authorized networks are actually called allowed networks #2761

merged 1 commit into from
Feb 7, 2020

Conversation

fanf
Copy link
Member

@fanf fanf commented Feb 6, 2020 •
edited
Loading

https://issues.rudder.io/issues/16692

  • change "authorized networks" to "allowed networks" so that it matches UI/documentation,
  • if a policy server is missing allowed network policy, we want to return an empty list of networks in place of failing,
  • if the user didn't specify "allowed_networks" param, don't erase all allowed networks but fail.

@fanf
Copy link
Member Author

fanf commented Feb 6, 2020

wait, we have back the erasure of everything when we supply incorrect name

@fanf
Copy link
Member Author

fanf commented Feb 6, 2020

PR updated with a new commit

@fanf fanf requested a review from ncharles February 6, 2020 20:12
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2761
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/20085/console)

@fanf
Copy link
Member Author

fanf commented Feb 7, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_16692/authorized_networks_are_actually_called_allowed_networks branch from 45e27e3 to 5a40684 Compare February 7, 2020 08:29
@fanf fanf merged commit 5a40684 into Normation:branches/rudder/5.0 Feb 7, 2020
@fanf fanf deleted the bug_16692/authorized_networks_are_actually_called_allowed_networks branch March 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

@ncharles ncharles Awaiting requested review from ncharles

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@fanf @Normation-Quality-Assistant @VinceMacBuche