Fixes #16730: Update users configuration file to add BCrypt support #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
approved these changes
Feb 13, 2020
amousset
reviewed
Feb 13, 2020
| @@ -70,9 +73,9 @@ | |||
| into account: /etc/init.d/rudder-jetty restart | |||
| --> | |||
|
|
|||
| <authentication hash="sha512"> | |||
| <authentication hash="bcrypt"> | |||
|
|
|||
| <!-- Default credentials: admin / admin --> | |||
There was a problem hiding this comment.
we should not keep this comment
|
OK, merging this PR |
fanf
requested changes
Feb 13, 2020
|
|
||
| Not specifying the "hash" attribute means using plain text passwords, which is not | ||
| adviseable for security reasons. | ||
|
|
||
| To create a bcrypt hash of your password, please run this command: | ||
| htpasswd -nBC 12 "" | tr -d ':\n' | sed 's/$2y/$2b/' |
There was a problem hiding this comment.
Is the sed really necessary? The compare algo should work with "2y", and it's a risk that user do ad thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16730