Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16846: tests changes to prepare rudder-lang integration #2802

Merged
merged 2 commits into from Mar 12, 2020
Merged

Fixes #16846: tests changes to prepare rudder-lang integration #2802

merged 2 commits into from Mar 12, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Mar 2, 2020

https://issues.rudder.io/issues/16846

wip preparing production test loop to work out of the box hopefully

@gpoblon gpoblon force-pushed the ust_16846/tests_changes_to_prepare_rudder_lang_integration branch 4 times, most recently from 8d4aeb4 to 4ef8cf2 Compare March 5, 2020 09:51
@peckpeck
Copy link
Member

You need a rebase here

@gpoblon gpoblon force-pushed the ust_16846/tests_changes_to_prepare_rudder_lang_integration branch 5 times, most recently from 87af52d to 2dd66f3 Compare March 10, 2020 15:33
peckpeck
peckpeck requested changes Mar 10, 2020
View reviewed changes
rudder-lang/tools/cfjson_tester Outdated Show resolved Hide resolved
rudder-lang/tools/tester-dev.sh Show resolved Hide resolved
rudder-lang/tools/cfjson_tester Outdated Show resolved Hide resolved
@gpoblon
Copy link
Contributor Author

gpoblon commented Mar 10, 2020

PR updated with a new commit

@gpoblon gpoblon force-pushed the ust_16846/tests_changes_to_prepare_rudder_lang_integration branch 2 times, most recently from b7a7c9a to cf95e01 Compare March 12, 2020 09:20
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2802
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/21388/console)

@peckpeck
Copy link
Member

OK, squash merging this PR

@peckpeck peckpeck force-pushed the ust_16846/tests_changes_to_prepare_rudder_lang_integration branch from cf95e01 to f1f665f Compare March 12, 2020 12:20
@peckpeck
Copy link
Member

OK, merging this PR

@peckpeck peckpeck merged commit f1f665f into Normation:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck requested changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@gpoblon @peckpeck @Normation-Quality-Assistant