Fixes #16878: Fix generation of parameters and conditions from cfengine files #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Mar 13, 2020
|
PR updated with a new commit |
gpoblon
force-pushed
the
bug_16878/fix_generation_of_parameters_and_conditions_from_cfengine_files_r
branch
from
65f1a60
to
f079b4a
Compare
|
Test failing |
peckpeck
approved these changes
Mar 19, 2020
|
This PR is not mergeable to upper versions. |
|
@gpoblon there are conflits, you must rebase |
|
OK, squash merging this PR |
gpoblon
force-pushed
the
bug_16878/fix_generation_of_parameters_and_conditions_from_cfengine_files_r
branch
from
f079b4a
to
2e8e5b4
Compare
|
rebased, ready to merge |
|
@gpoblon Tests are failing |
|
Yes they are until the next enum PR goes in, @peckpeck is working on it. The oslib.rl does not match the new enum system yet, hence the failing tests |
|
OK, squash merging this PR |
peckpeck
force-pushed
the
bug_16878/fix_generation_of_parameters_and_conditions_from_cfengine_files_r
branch
from
2e8e5b4
to
d5e196a
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16878
bug corrections : parameters partly done, and conditions fix, parenthesis conditions a bit better