Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #16938: Improve compiler options #2830

Merged
merged 1 commit into from Mar 19, 2020
Merged

Fixes #16938: Improve compiler options #2830

merged 1 commit into from Mar 19, 2020

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from peckpeck March 19, 2020 14:30
@amousset
Copy link
Member Author

First commit is a cargo fmt

@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2830
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/21653/console)

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the ust_16938/improve_compiler_options branch from 1f43b64 to 0691d06 Compare March 19, 2020 15:24
@amousset amousset merged commit d5a5d4c into Normation:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @peckpeck