Fixes #17079: Test files are not correctly clean #2877
Conversation
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
| val t0 = System.nanoTime | ||
|
|
||
| for (i <- 1 to 100) { | ||
| val t0_0 = System.nanoTime | ||
| val result = ComplianceLevel.sum(source) |
There was a problem hiding this comment.
these should not be removed. They are used to warm the JVM, plus are not at all related to this ticket
There was a problem hiding this comment.
Those variable are unused, and really look like dead code, so definetly related to this issue
There was a problem hiding this comment.
@ncharles if they are useful, we need a way to mark them as that. I regularly remove things that lead to warning or looks like dead code. At minima, they need to have:
- a comment to explain why they are here,
- a silent annotation to remove warning.
Rudder should build with 0 warning
|
PR updated with a new commit |
| @@ -74,7 +75,9 @@ class HooksTest() extends Specification with AfterAll { | |||
| } | |||
|
|
|||
| override def afterAll(): Unit = { | |||
| // tmp.delete() | |||
| if(System.getProperty("tests.clean.tmp") != "false") { | |||
| File("/tmp/rudder-test-hook/").delete() | |||
There was a problem hiding this comment.
In think @amousset will be very happy (test will now be cleaned up ....)
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_17079/test_files_are_not_correctly_clean
branch
from
f96efed
to
f929668
Compare
https://issues.rudder.io/issues/17079