Fixes #16636: Purge of unreferenced software may fail on very large system #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
Apr 14, 2020
| @@ -123,18 +123,24 @@ class ReadOnlySoftwareDAOImpl( | |||
|
|
|||
| // fetch all nodes | |||
| nodes = con.searchSub(nodeBaseSearch, IS(OC_NODE), A_NODE_UUID) | |||
| batchedNodes = nodes.grouped(50).toSeq | |||
|
|
|||
| batchedNodes = nodes.grouped(25).toSeq | |||
There was a problem hiding this comment.
can you put the 25 in a var and use that var in log? I'm almost (to be fair with me) that I would forget half of the change if I ever touch that
|
PR updated with a new commit |
fanf
approved these changes
Apr 14, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
ncharles
force-pushed
the
bug_16636/purge_of_unreferenced_software_may_fail_on_very_large_system
branch
from
860a1e9
to
984b605
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/16636