Fixes #17141: when we add a multiline description in Technique, it breaks policy generation and technique loading #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Apr 16, 2020
| @@ -354,7 +354,7 @@ class ClassicTechniqueWriter(basePath : String, parameterTypeService: ParameterT | |||
|
|
|||
| val content = | |||
| s"""# @name ${technique.name} | |||
| |# @description ${technique.description} | |||
| |# @description ${technique.description.split("\n").mkString("\n# ")} | |||
There was a problem hiding this comment.
and perhaps [\n\r]{1,2} ? Not sure what browser on windows do?
There was a problem hiding this comment.
according to https://stackoverflow.com/questions/454908/split-java-string-by-new-line , which point to https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html, \R should do the trick
|
PR updated with a new commit |
ncharles
approved these changes
Apr 16, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…eaks policy generation and technique loading
VinceMacBuche
force-pushed
the
bug_17141/when_we_add_a_multiline_description_in_technique_it_breaks_policy_generation_and_technique_loading
branch
from
eea3edb
to
97af16e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17141