Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17183: Add Create Node endpoint in API documentation #2916

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Apr 23, 2020

@ElaadF ElaadF requested a review from amousset April 23, 2020 07:30
@ElaadF ElaadF force-pushed the bug_17183/add_create_node_endpoint_in_api_documentation branch from 7ef895c to 0313b1f Compare April 23, 2020 07:40
@ElaadF
Copy link
Member Author

ElaadF commented Apr 23, 2020

Commit modified

@ElaadF
Copy link
Member Author

ElaadF commented Apr 23, 2020

Commit modified

@ElaadF ElaadF force-pushed the bug_17183/add_create_node_endpoint_in_api_documentation branch from 0313b1f to 0f08fd4 Compare April 23, 2020 08:39
- hostname
- status
- os
# - policyServerId [Optional, by default "root"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it commented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these were required fields, but there are optional so I comment them for better understanding, to keep track

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit b0c7b93 into Normation:branches/rudder/6.1 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants