Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17228: Rudder 6.1 does not start anymore #2929

Conversation

fanf
Copy link
Member

@fanf fanf commented Apr 24, 2020

@fanf fanf requested a review from VinceMacBuche April 24, 2020 16:29
@@ -88,6 +88,7 @@ import com.normation.rudder.batch._
import com.normation.rudder.db.Doobie
import com.normation.rudder.domain._
import com.normation.rudder.domain.logger.ApplicationLogger
import com.normation.rudder.domain.logger.ApplicationLoggerPure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import not needed i think!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right!

@fanf
Copy link
Member Author

fanf commented Apr 24, 2020

PR updated with a new commit

@fanf fanf requested a review from VinceMacBuche April 24, 2020 22:04
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2929
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/23662/console)

@amousset
Copy link
Member

OK, squash merging this PR

@amousset amousset force-pushed the bug_17228/rudder_6_1_does_not_start_anymore branch from ac6001d to 63fecc0 Compare April 25, 2020 05:56
@amousset
Copy link
Member

OK, merging this PR

@amousset amousset merged commit 63fecc0 into Normation:branches/rudder/6.1 Apr 25, 2020
@fanf fanf deleted the bug_17228/rudder_6_1_does_not_start_anymore branch March 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants