Fixes #17237: Do not compute dynamic groups if nothing changed in LDAP #2931
Conversation
|
|
||
| override def changesSince(lastTime: DateTime): Box[Boolean] = { | ||
| val n0 = System.currentTimeMillis | ||
| if(n0 < lastTime.getMillis || n0 - lastTime.getMillis < 100) { |
There was a problem hiding this comment.
does that mean a change in the future?
There was a problem hiding this comment.
ah yes, it's not usefull in fact (because if the first is true, the second is also). I will remove it.
| , AND(IS(OC_RUDDER_NODE), Filter.create(s"entryDN:dnOneLevelMatch:=ou=Nodes,cn=rudder-configuration")) | ||
| , AND(IS(OC_RUDDER_NODE_GROUP), Filter.create(s"entryDN:dnSubtreeMatch:=groupCategoryId=GroupRoot,ou=Rudder,cn=rudder-configuration")) | ||
| ) | ||
| , GTEQ("modifyTimestamp", GeneralizedTime(lastTime).toString) |
There was a problem hiding this comment.
we don't have index for that. It will be really costly on ldap
There was a problem hiding this comment.
also, is there a way to stop the query if one result is found ?
There was a problem hiding this comment.
it's actually stop on the first (or second?) hit, so it is (a bit, but still much less that group search) costly only if there's no modifications. We do something very similar for cache, and it's quite fast.
(openldap seem to be very efficient in pruning entries that he don't care on that. The fact that keys are sorted in mdb may be the reason, I don't know).
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
ust_17237/do_not_compute_dynamic_groups_if_nothing_changed_in_ldap
branch
from
87f4d4d
to
3164d5b
Compare
https://issues.rudder.io/issues/17237