Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17403: refactoring io usage and configuration #2972

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fixes #17403: refactoring io usage and configuration #2972

merged 1 commit into from
Jun 2, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented May 14, 2020

@gpoblon gpoblon force-pushed the ust_17403/refactoring_io_usage_and_configuration branch from 0aadacb to d099a59 Compare May 14, 2020 15:07
@gpoblon
Copy link
Contributor Author

gpoblon commented May 14, 2020

still requires some work to properly handle other Generators

amousset
amousset reviewed May 14, 2020
View reviewed changes
rudder-lang/src/io.rs Outdated Show resolved Hide resolved
@gpoblon gpoblon changed the title Ust 17403/refactoring io usage and configuration Fixes #17403: refactoring io usage and configuration May 14, 2020
@gpoblon gpoblon changed the base branch from branches/rudder/6.1 to master May 19, 2020 07:31
@gpoblon gpoblon requested review from amousset and peckpeck June 1, 2020 08:23
@gpoblon gpoblon changed the base branch from master to branches/rudder/6.1 June 1, 2020 08:24
@gpoblon gpoblon changed the base branch from branches/rudder/6.1 to master June 1, 2020 08:24
@gpoblon gpoblon changed the base branch from master to branches/rudder/6.1 June 1, 2020 08:24
@gpoblon gpoblon force-pushed the ust_17403/refactoring_io_usage_and_configuration branch 2 times, most recently from 3415dc3 to 52c947a Compare June 1, 2020 12:09
@amousset
Copy link
Member

amousset commented Jun 2, 2020

Why removing execution bit for rudder-lang/tools/tester.sh?

@gpoblon
Copy link
Contributor Author

gpoblon commented Jun 2, 2020 •
edited
Loading

I will roll it back to 755, did not change it on purpose

@gpoblon
Copy link
Contributor Author

gpoblon commented Jun 2, 2020

fixed

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/2972
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/25562/console)

@amousset
Copy link
Member

amousset commented Jun 2, 2020

OK, squash merging this PR

@amousset amousset force-pushed the ust_17403/refactoring_io_usage_and_configuration branch from 69c5d98 to 9dc3bc2 Compare June 2, 2020 15:24
@amousset amousset merged commit 9dc3bc2 into Normation:branches/rudder/6.1 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

@peckpeck peckpeck Awaiting requested review from peckpeck

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@gpoblon @amousset @Normation-Quality-Assistant