Fixes #17482: Webapp block at start on inventory processing #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
|
PR rebased |
fanf
force-pushed
the
bug_17482/webapp_block_at_start_on_inventory_processing
branch
from
b5289de
to
d11d446
Compare
|
PR updated with a new commit |
| } catch { | ||
| // Execution context is not used here - binding to scala default global | ||
| @silent("private default argument.*is never used") | ||
| override def start()(implicit executionContext: ExecutionContext = scala.concurrent.ExecutionContext.global): Unit = { |
There was a problem hiding this comment.
Have you tried removing the execution context ?
There was a problem hiding this comment.
it's in parent method signature, I can't. But I moved it to call site, it avoids half of them.
There was a problem hiding this comment.
Ha yes, we override better-files file monitor
|
PR updated with a new commit |
VinceMacBuche
approved these changes
May 25, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_17482/webapp_block_at_start_on_inventory_processing
branch
from
9f03570
to
8749a90
Compare
fanf
deleted the
bug_17482/webapp_block_at_start_on_inventory_processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17482