Fixes #17521: A repaired in system policies should not be seen as a problem for warning display in nodes list #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
May 26, 2020
|
|
||
| function reportsSum (complianceArray) { | ||
| if (Array.isArray(complianceArray)) { | ||
| return complianceArray.reduce(function(total, value) { return total + reduce} ) |
There was a problem hiding this comment.
what happen for reduce when array size is 1? Does it correcty returns the value, or does it fails ?
There was a problem hiding this comment.
should be total+value
(and it's ok for size == 1, I just checked)
fanf
requested changes
May 26, 2020
|
|
||
| function reportsSum (complianceArray) { | ||
| if (Array.isArray(complianceArray)) { | ||
| return complianceArray.reduce(function(total, value) { return total + reduce} ) |
There was a problem hiding this comment.
should be total+value
(and it's ok for size == 1, I just checked)
|
PR updated with a new commit |
fanf
approved these changes
May 26, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…roblem for warning display in nodes list
fanf
force-pushed
the
bug_17521/a_repaired_in_system_policies_should_not_be_seen_as_a_problem_for_warning_display_in_nodes_list
branch
from
ec3e922
to
961410e
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17521