Fixes #17568: Allow to regenerate generic methods when there is a new one

[VinceMacBuche]

https://issues.rudder.io/issues/17568

[fanf]

why not file.collectChildren(your extension filter) ?

[fanf]

That seems inefficient. You could either collect directly max time when you iterate on childrens (map is not lazy, so you will go through all children for it), or even pass the comparison date in your collect's filter so that you just have to check for iterator.nonEmpty (which should stop on first match)

[VinceMacBuche]

PR updated with a new commit

[fanf]

I think the logic is OK and you can self merge. I added a comment to help you see how you could make the code easier to test, but it's not a required change, I let you decide.

[fanf]

I think it's ok but it's hard to test as it is. What would make it easier to test is to have it split in two:

• one part with the logic and parameters for all states,
• one methods that set state for user convenience, ie:

 // this one contains logic but stateless and so easy to test - actually, we could make it pure
 // with an `IORestul.effect` around last statement
  private[this] def checkNeedsUpdate(lastTime: TimeType, dirs: List[File]) : Boolean = {
    def isAMethodNewerThanCache(file : File) : Boolean = {
      file.isRegularFile && file.extension(false).map(_ == "cf").getOrElse(false)  && lastTime.isAfter(methodsFileModifiedTime)
    }
    dirs.exist(dir => dir.collectChildren(isAMethodNewerThanCache).isEmpty)
  }
  // this one is convenient and meaningful to use in the code (but untestable)
  private[this] def doesMethodsMetadataFileNeedsUpdate : Boolean = {
    val methodsFileModifiedTime = methodsFile.lastModifiedTime()
    val baseDir = root / "usr" / "share" / "ncf" / "tree" / "30_generic_methods"
    val userDir = configuration_repository / "ncf" / "30_generic_methods"
   checkNeedsUpdate(methodsFileModifiedTime, baseDir :: userDir :: Nil)
  }

[VinceMacBuche]

PR updated with a new commit

[fanf]

this is an IO too :)

[VinceMacBuche]

PR updated with a new commit

[Normation-Quality-Assistant]

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3024
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/25506/console)

[fanf]

OK, squash merging this PR