Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17588: Add email path parameter in RUDDER config file #3030

Closed
wants to merge 1 commit into from
Closed

Fixes #17588: Add email path parameter in RUDDER config file #3030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions webapp/sources/rudder/rudder-web/src/main/scala/bootstrap/liftweb/RudderConfig.scala
View file
Open in desktop
Expand Up @@ -258,6 +258,16 @@ object RudderConfig extends Loggable {

//other values

val RUDDER_EMAIL_CONF = {
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why you want to put it in rudder ? Email config is only for one plugin, right?
Is there a constraint I don't see? If so, it need to be documented in the corresponding code, else it will get corrupted/changed at some point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I told @ElaadF To close this PR and to put it only in the plugin code in private. We don't need this information in Rudder, i agrre with you

Some(config.getString("rudder.email.settings"))
} catch {
case ex: ConfigException =>
ApplicationLogger.debug("Property 'rudder.email.settings' is missing or empty in rudder.configFile.")
None
}
}

val LDAP_HOST = config.getString("ldap.host")
val LDAP_PORT = config.getInt("ldap.port")
val LDAP_AUTHDN = config.getString("ldap.authdn")
Expand Down