Fixes #17646: Clicking on the warning icon is node list should lead to system status page #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o system status page
ElaadF
commented
Jun 5, 2020
| @@ -80,7 +80,7 @@ object ShowNodeDetailsFromNode { | |||
| sealed trait DisplayDetailsMode { def tab : Int} | |||
| case object Summary extends DisplayDetailsMode { override def tab = 0 } | |||
| case object Compliance extends DisplayDetailsMode { override def tab = 1 } | |||
| case object System extends DisplayDetailsMode { override def tab = 6 } | |||
There was a problem hiding this comment.
I'm not sure if it was a mistake or on purpose
There was a problem hiding this comment.
The tab changed between first implem, and was originally in 7 position, but someone changed the tab order, but not here
VinceMacBuche
approved these changes
Jun 5, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17646