Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17774: Duplicate category name error when saving a new user technique #3082

Conversation

fanf
Copy link
Member

@fanf fanf commented Jun 17, 2020

@fanf fanf requested a review from VinceMacBuche June 17, 2020 20:21
@fanf
Copy link
Member Author

fanf commented Jun 17, 2020

PR updated with a new commit

@@ -117,9 +126,8 @@ class TechniqueAcceptationUpdater(
@scala.annotation.tailrec
def createCategories(names: List[CategoryInfo], parentCategory: (ActiveTechniqueCategoryId, String)): (ActiveTechniqueCategoryId, String) = {
names match {
case Nil => parentCategory
case head::tail =>
val info = names.head
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well. We were young.

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3082
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/26394/console)

@fanf
Copy link
Member Author

fanf commented Jun 17, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_17774/duplicate_category_name_error_when_saving_a_new_user_technique branch from 714e81c to 3c14607 Compare June 17, 2020 22:55
@fanf fanf merged commit 3c14607 into Normation:branches/rudder/5.0 Jun 17, 2020
@fanf fanf deleted the bug_17774/duplicate_category_name_error_when_saving_a_new_user_technique branch March 15, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants