Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17585: dsc integration #3089

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fixes #17585: dsc integration #3089

merged 1 commit into from
Jun 23, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Jun 18, 2020 •
edited
Loading

@gpoblon
Copy link
Contributor Author

gpoblon commented Jun 18, 2020

a lot of work, hard to split

  • dsc generation partly working (no statements, no distinction between dsc and classic generic methods)
  • class_parameter metadata integration to handle parameters from ncf libs
  • fix missing generic methods
  • cleaned some cfengine generation

todo:

  • fix cfengine class_parameters generation (was broken sometimes)
  • make distinction between dsc and classic generic methods
  • add statements, expressions etc

@peckpeck
Copy link
Member

@gpoblon you need rebase

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3089
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/26651/console)

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3089
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/26653/console)

@gpoblon
Copy link
Contributor Author

gpoblon commented Jun 23, 2020

rebased

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 89651a6 into Normation:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

@amousset amousset Awaiting requested review from amousset

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@gpoblon @peckpeck @Normation-Quality-Assistant