Fixes #17660: Node details summary compliance contains system rules #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
requested changes
Jun 25, 2020
| // Get only user rules. | ||
| rules <- roRuleRepository.getIds(false).toBox.toOption | ||
| // We don't want to continue if we have no user rules, and an empty set will put all rules, and here systems rule only | ||
| if rules.size > 0 |
There was a problem hiding this comment.
this is a feature of for comprehension that we don't use anywhere else, and is not compatible with most other for comprehension (it won't work with zio for ex, because there's no withFilter).
|
PR updated with a new commit |
fanf
approved these changes
Jun 26, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_17660/node_details_summary_compliance_contains_system_rules
branch
from
7888f2b
to
2eefd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17660