Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18025: Use node properties as path for node properties #3136

Merged
merged 1 commit into from Jul 24, 2020
Merged

Fixes #18025: Use node properties as path for node properties #3136

merged 1 commit into from Jul 24, 2020

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche VinceMacBuche requested a review from fanf July 22, 2020 15:37
@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

2 similar comments
@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3136
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/28026/console)

@VinceMacBuche
Copy link
Member Author

OK, squash merging this PR

@VinceMacBuche VinceMacBuche force-pushed the bug_18025/use_node_properties_as_path_for_node_properties branch from e88c66e to 8970a8e Compare July 24, 2020 08:02
@VinceMacBuche VinceMacBuche merged commit 8970a8e into Normation:branches/rudder/6.1 Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@VinceMacBuche @Normation-Quality-Assistant @fanf