Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18047: tests clean 2 #3143

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fixes #18047: tests clean 2 #3143

merged 1 commit into from
Jul 28, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Jul 28, 2020

@gpoblon gpoblon requested a review from peckpeck July 28, 2020 14:43
amousset
amousset reviewed Jul 28, 2020
View reviewed changes
relay/sources/Makefile Outdated Show resolved Hide resolved
@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 28, 2020

PR updated with a new commit

@gpoblon gpoblon requested a review from amousset July 28, 2020 14:55
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3143
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/28198/console)

@gpoblon
Copy link
Contributor Author

gpoblon commented Jul 28, 2020

OK, squash merging this PR

@gpoblon gpoblon merged commit 6762a25 into Normation:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

@amousset amousset Awaiting requested review from amousset

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
4 participants
@gpoblon @Normation-Quality-Assistant @amousset @peckpeck