Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18081: move toml data into rudderlang stdlib #3157

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fixes #18081: move toml data into rudderlang stdlib #3157

merged 1 commit into from
Aug 4, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Aug 3, 2020

@gpoblon gpoblon requested a review from amousset August 3, 2020 18:18
@gpoblon
Copy link
Contributor Author

gpoblon commented Aug 4, 2020

PR updated with a new commit

@gpoblon gpoblon requested a review from amousset August 4, 2020 02:56
@gpoblon gpoblon force-pushed the ust_18081/move_toml_data_into_rudderlang_stdlib branch from 65e4d09 to f11a070 Compare August 4, 2020 03:03
@gpoblon
Copy link
Contributor Author

gpoblon commented Aug 4, 2020

Commit modified

@gpoblon gpoblon force-pushed the ust_18081/move_toml_data_into_rudderlang_stdlib branch from f11a070 to 31ef536 Compare August 4, 2020 03:05
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3157
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/28485/console)

@gpoblon
Copy link
Contributor Author

gpoblon commented Aug 4, 2020

OK, squash merging this PR

@gpoblon gpoblon force-pushed the ust_18081/move_toml_data_into_rudderlang_stdlib branch from 31ef536 to 74adb23 Compare August 4, 2020 08:15
@gpoblon gpoblon merged commit 74adb23 into Normation:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@gpoblon @Normation-Quality-Assistant @amousset