Fixes #10216: "id" setting is silently ignored for new group created through the REST API. #3194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
added
the
WIP
| @@ -353,7 +353,10 @@ class GroupApiService2 ( | |||
| implicit val prettify = restExtractor.extractPrettify(req.params) | |||
| val modId = ModificationId(uuidGen.newUuid) | |||
| val actor = RestUtils.getActor(req) | |||
| val groupId = NodeGroupId(req.param("id").getOrElse(uuidGen.newUuid)) | |||
There was a problem hiding this comment.
It could have been done like we do in Rules / Directives
val id = restExtractor.extractId(req)(x => Full(NodeGroupId(x))).map(_.getOrElse(NodeGroupId(uuidGen.newUuid)))
…d through the REST API.
ElaadF
force-pushed
the
bug_10216/id_setting_is_silently_ignored_for_new_group_created_through_the_rest_api
branch
from
56b52db
to
bb3e8bc
Compare
|
Commit modified |
ElaadF
removed
the
WIP
VinceMacBuche
approved these changes
Aug 27, 2020
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/10216