Fixes #18168: command line rework #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Sep 16, 2020
| let result = match action { | ||
| Action::Compile => compile_file(&ctx, true), | ||
| Action::Translate => generate(&ctx), |
There was a problem hiding this comment.
Where does the generate call go ?
There was a problem hiding this comment.
disappears in next PR, unused since actions are not Translate and Compile anymore
peckpeck
reviewed
Sep 16, 2020
| } | ||
| // TODO might try to merge io.rs in here | ||
| impl IOContext { | ||
| pub fn set(action: Action, opt: &GenericOptions, format: Option<Format>) -> Result<Self> { |
There was a problem hiding this comment.
set is a too generic name, what does it do ?
isn't thei a new() ?
There was a problem hiding this comment.
yes, will be updated
peckpeck
approved these changes
Sep 21, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18168