-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #17250: Webapp does not regerate policies when webdav password is changed, breaking inventories after 5.0 -> 6.0 upgrade #3217
Conversation
…into branches/rudder/6.1
…roblem for warning display in nodes list
…een_as_a_problem_for_warning_display_in_nodes_list_pr' into branches/rudder/6.1
…into branches/rudder/6.1
…_pr' into branches/rudder/6.1
…b on node details shows an error
…development_environement_in_6_1_pr' into branches/rudder/6.1
… in 6.1 blocks all technique updates
…hed_change_in_6_1_pr' into branches/rudder/6.1
… into branches/rudder/6.1
…tails_pr' into branches/rudder/6.1
…/ added ) are commited automatically during upgrade
@@ -65,10 +67,11 @@ class TriggerPolicyUpdate( | |||
try { | |||
if (file.exists) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why keep that test? I would just remove it and deprecate both flag files. And document it.
And in 7.0 remove the files enterily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that people are not surprised as some are used to use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so make the test only to adapt message, and put out the start, wichi is not subject to condition.
And I think we need to adapt the message to tell "you don't need that file, since 6.1.x start is automatic".
And I think we must do it only in 6.1: 6.0 is EOL and it complicate the explanation about when the behavior changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I do indeed need to remove the other one
…is changed, breaking inventories after 5.0 -> 6.0 upgrade
bab5eca
to
2cb0ac2
Compare
PR replaced by #3218 |
https://issues.rudder.io/issues/17250