Fixes #17250: Webapp does not regerate policies when webdav password is changed, breaking inventories after 5.0 -> 6.0 upgrade #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into branches/rudder/6.1
…roblem for warning display in nodes list
…een_as_a_problem_for_warning_display_in_nodes_list_pr' into branches/rudder/6.1
…into branches/rudder/6.1
…_pr' into branches/rudder/6.1
…b on node details shows an error
…development_environement_in_6_1_pr' into branches/rudder/6.1
… in 6.1 blocks all technique updates
…hed_change_in_6_1_pr' into branches/rudder/6.1
… into branches/rudder/6.1
…tails_pr' into branches/rudder/6.1
…/ added ) are commited automatically during upgrade
fanf
requested changes
Sep 17, 2020
| @@ -65,10 +67,11 @@ class TriggerPolicyUpdate( | |||
| try { | |||
| if (file.exists) { | |||
There was a problem hiding this comment.
Why keep that test? I would just remove it and deprecate both flag files. And document it.
And in 7.0 remove the files enterily.
There was a problem hiding this comment.
so that people are not surprised as some are used to use it
There was a problem hiding this comment.
ok, so make the test only to adapt message, and put out the start, wichi is not subject to condition.
And I think we need to adapt the message to tell "you don't need that file, since 6.1.x start is automatic".
And I think we must do it only in 6.1: 6.0 is EOL and it complicate the explanation about when the behavior changed.
There was a problem hiding this comment.
but I do indeed need to remove the other one
…is changed, breaking inventories after 5.0 -> 6.0 upgrade
ncharles
force-pushed
the
bug_17250/webapp_does_not_regerate_policies_when_webdav_password_is_changed_breaking_inventories_after_5_0_6_0_upgrade
branch
from
bab5eca
to
2cb0ac2
Compare
|
PR replaced by #3218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17250