Fixes #18277: Bad condition on name checking for technique existence #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -336,15 +336,14 @@ class NcfApi( | |||
| } ) | |||
| } | |||
|
|
|||
| private def isTechniqueNameExist(name: TechniqueName, bundleName: BundleName) = { | |||
| private def isTechniqueNameExist(bundleName: BundleName) = { | |||
| for { | |||
| lib <- readDirective.getFullDirectiveLibrary() | |||
| activeTechniques = lib.allActiveTechniques.values.toSeq | |||
| userTechniques <- techniqueReader.readTechniquesMetadataFile | |||
There was a problem hiding this comment.
Why do you get all user techniques ? They should already be in activeTechniques
ElaadF
force-pushed
the
bug_18277/bad_condition_on_name_checking_for_technique_existence
branch
from
c7bc70f
to
6ab9a48
Compare
|
Commit modified |
ElaadF
force-pushed
the
bug_18277/bad_condition_on_name_checking_for_technique_existence
branch
from
6ab9a48
to
704ae4f
Compare
|
Commit modified |
fanf
approved these changes
Oct 2, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18277