Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18276: clean and refactor modules and folders #3238

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Fixes #18276: clean and refactor modules and folders #3238

merged 2 commits into from
Oct 15, 2020

Conversation

gpoblon
Copy link
Contributor

@gpoblon gpoblon commented Oct 2, 2020

@gpoblon gpoblon requested a review from peckpeck October 2, 2020 09:42
@gpoblon gpoblon force-pushed the arch_18276/clean_and_refactor_modules_and_folders branch from 91b4f5f to 022a738 Compare October 2, 2020 09:51
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 2, 2020

Commit modified

@gpoblon gpoblon force-pushed the arch_18276/clean_and_refactor_modules_and_folders branch from 022a738 to 88aeff7 Compare October 2, 2020 10:12
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 2, 2020

Commit modified

@gpoblon gpoblon force-pushed the arch_18276/clean_and_refactor_modules_and_folders branch from 88aeff7 to c0f43a5 Compare October 8, 2020 13:25
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 13, 2020

PR updated with a new commit

@gpoblon gpoblon force-pushed the arch_18276/clean_and_refactor_modules_and_folders branch from bfec9dc to de0a81e Compare October 13, 2020 09:37
@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 13, 2020

Commit modified

@gpoblon gpoblon force-pushed the arch_18276/clean_and_refactor_modules_and_folders branch from de0a81e to df5ed88 Compare October 13, 2020 09:38
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3238
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/30931/console)

@gpoblon
Copy link
Contributor Author

gpoblon commented Oct 15, 2020

OK, squash merging this PR

@gpoblon gpoblon force-pushed the arch_18276/clean_and_refactor_modules_and_folders branch from df5ed88 to 667b1c1 Compare October 15, 2020 07:14
@gpoblon gpoblon merged commit 667b1c1 into Normation:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@gpoblon @Normation-Quality-Assistant @peckpeck