Fixes #18306: Create healthcheck API #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
added
the
WIP
ElaadF
commented
Oct 8, 2020
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
847ef8f
to
2f7851c
Compare
|
Commit modified |
fanf
requested changes
Oct 8, 2020
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
...ources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/lift/HealthcheckApi.scala
Outdated
Show resolved
Hide resolved
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
2f7851c
to
10b76e4
Compare
|
Commit modified |
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
10b76e4
to
556625d
Compare
|
Commit modified |
fanf
requested changes
Oct 9, 2020
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Show resolved
Hide resolved
...udder-core/src/main/scala/com/normation/rudder/services/healthcheck/HealthcheckService.scala
Outdated
Show resolved
Hide resolved
...sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/RestDataSerializer.scala
Outdated
Show resolved
Hide resolved
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
556625d
to
31b40ec
Compare
|
Commit modified |
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
31b40ec
to
e21c080
Compare
|
Commit modified |
fanf
reviewed
Oct 9, 2020
...ources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/EndpointsDefinition.scala
Outdated
Show resolved
Hide resolved
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
e21c080
to
d7de582
Compare
|
Commit modified |
fanf
reviewed
Oct 12, 2020
| availableCores <- IOResult.effect(getRuntime.availableProcessors) | ||
| } yield { | ||
| availableCores match { | ||
| case 0 => Critical("No Core available") |
There was a problem hiding this comment.
it should really be case i if i <= 0 => because 0 core is an error (it can't be otherwise), and in case of error, you can't, make any assumption about what will be returned beside what the type contraints (an error is often a negative number in C-like semantic).
ElaadF
force-pushed
the
ust_18306/create_healthcheck_api
branch
from
d7de582
to
b8823dc
Compare
|
Commit modified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18306