Fixes #18317: Support source package in Rudder inventory #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
VinceMacBuche
changed the base branch from
branches/rudder/6.1
to
branches/rudder/6.2
fanf
reviewed
Oct 12, 2020
| @@ -90,7 +90,7 @@ class NameAndVersionIdFinder( | |||
| } yield { | |||
| //now merge back | |||
| entities.foldLeft(MergedSoftware(Set(),Set())) { case(ms, s) => | |||
| merged.find { x => x.name == s.name && x.version == s.version } match { | |||
| merged.find { x => x == s } match { | |||
There was a problem hiding this comment.
I don't think we want to compare ALL fields ? Only name, version, source name, source version ?
|
PR updated with a new commit |
fanf
requested changes
Oct 21, 2020
webapp/sources/ldap-inventory/inventory-repository/src/main/resources/ldap/inventory.schema
Show resolved
Hide resolved
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
fanf
approved these changes
Oct 22, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
VinceMacBuche
force-pushed
the
bug_18317/support_source_package_in_rudder_inventory
branch
from
66f8d9f
to
06f05f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18317