Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18363: Add check name in healthcheck API #3283

Conversation

ElaadF
Copy link
Member

@ElaadF ElaadF commented Oct 21, 2020

@ElaadF ElaadF force-pushed the arch_18363/add_check_name_in_healthcheck_api branch from e8023c0 to 64860f1 Compare October 21, 2020 08:25
@ElaadF
Copy link
Member Author

ElaadF commented Oct 21, 2020

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/6.2' set up to track remote branch 'branches/rudder/6.2' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/6.2'.
Already up to date.
Already up to date.
[...]
+ '[' --merge = --relayd ']'
+ '[' --merge = --language ']'
+ '[' --merge = --scala ']'
+ webapp/sources/rudder/rudder-core/src/test/resources/hooks.d/test-hooks.sh
+ export PYTHONPATH=./relay/sources/rudder-pkg/lib/rudder-pkg/:./relay/sources/rudder-pkg/lib:
+ PYTHONPATH=./relay/sources/rudder-pkg/lib/rudder-pkg/:./relay/sources/rudder-pkg/lib:
+ find . '!' -name convertOpenLDAPSchema.py '!' -wholename '*jsondiff/*' -name '*.py'
+ xargs pylint -E --persistent=n --disable=C,R,import-error,no-member,no-name-in-module
No config file found, using default configuration

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder/pull/3283 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/31290/console)

@amousset
Copy link
Member

Could you also update the API doc?

@VinceMacBuche
Copy link
Member

Do it in this PR Elaad

@ElaadF ElaadF force-pushed the arch_18363/add_check_name_in_healthcheck_api branch from 64860f1 to 81bf614 Compare October 21, 2020 09:45
@ElaadF
Copy link
Member Author

ElaadF commented Oct 21, 2020

Commit modified

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit e2546ed into Normation:branches/rudder/6.2 Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants