Fixes #18395: Update dependencies for the webapp #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
fanf
reviewed
Oct 22, 2020
| @@ -50,7 +50,7 @@ import com.normation.zio.ZioRuntime | |||
| import zio._ | |||
| import zio.syntax._ | |||
| import com.normation.zio._ | |||
| import org.apache.commons.lang.StringUtils | |||
| import org.apache.commons.lang3.StringUtils | |||
There was a problem hiding this comment.
Do you remember why we need to use that here, and only here? Perf reason ?
There was a problem hiding this comment.
|
PR updated with a new commit |
fanf
approved these changes
Oct 22, 2020
|
This PR is not mergeable to upper versions. |
fanf
approved these changes
Oct 22, 2020
|
OK, squash merging this PR |
fanf
force-pushed
the
arch_18395/update_dependencies_for_the_webapp
branch
from
0266a37
to
5a1744e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18395