Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18462: Compliance does not show up if you don't click on refresh #3316

Merged
merged 1 commit into from Nov 2, 2020
Merged

Fixes #18462: Compliance does not show up if you don't click on refresh #3316

merged 1 commit into from Nov 2, 2020

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche
Copy link
Member Author

WIP don't merge

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

1 similar comment
@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

fanf
fanf reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use to do compliance in a future because it was abysmally long to compute and the node page was then extremelly long to display. IIUC, you are removing that system. Is it OK perf wise?

...dder/rudder-core/src/main/scala/com/normation/rudder/services/reports/ReportingService.scala Show resolved Hide resolved
webapp/sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/lift/NodeApi.scala


def toComplianceArray(comp : ComplianceLevel) : JArray =
JArray (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we didn't do that anymore because of rounding errors, and that we were only using number of components / total number ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I send the same data we used to send

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, strange, I must be mistaken.

webapp/sources/rudder/rudder-rest/src/main/scala/com/normation/rudder/rest/lift/NodeApi.scala Outdated
n4 = System.currentTimeMillis
_ = TimingDebugLoggerPure.trace(s"Getting global mode: ${n4 - n3}ms")
_ = TimingDebugLoggerPure.trace(s"Getting compliance infos: ${n4 - n3}ms")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be that logger there, TimingDebugLoggerPure shouldn't do anything. You need to either call TimingDebugLogger or TimingDebugLoggerPure.logEffect

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3316
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/31890/console)

@fanf
Copy link
Member

fanf commented Nov 2, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_18462/compliance_does_not_show_up_if_you_don_t_click_on_refresh branch from 0e75e50 to e648d3e Compare November 2, 2020 20:01
@fanf fanf merged commit e648d3e into Normation:branches/rudder/6.2 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@VinceMacBuche @Normation-Quality-Assistant @fanf