Fixes #18482: Move health check API in /system/ #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Nov 4, 2020
ElaadF
force-pushed
the
arch_18482/move_health_check_api_in_system
branch
from
70648b1
to
6045c4b
Compare
|
Commit modified |
amousset
reviewed
Nov 4, 2020
| @@ -153,6 +151,8 @@ paths: | |||
| $ref: paths/system/archives-restore.yml | |||
| "/system/archives/{archiveKind}/zip/{commitId}": | |||
| $ref: paths/system/archives-zip.yml | |||
| "/system/healthcheck": | |||
| $ref: paths/system/healthcheck.yml | |||
There was a problem hiding this comment.
You also need to remove the "Health check" tag from the openapi.src.yml and healthcheck.yml files
ElaadF
force-pushed
the
arch_18482/move_health_check_api_in_system
branch
from
6045c4b
to
680d54e
Compare
|
Commit modified |
fanf
approved these changes
Nov 7, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18482