Fixes #18534: Skip non-standard moint FS for free-space check #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, you need to first filter to keep only lines starting with "/" and then keep the original logic of looking for "/var" or use "/" |
fanf
requested changes
Nov 9, 2020
ElaadF
force-pushed
the
ust_18534/skip_non_standard_moint_fs_for_free_space_check
branch
from
dab3ecc
to
39cf8fb
Compare
|
Commit modified |
fanf
requested changes
Nov 9, 2020
| @@ -96,7 +96,7 @@ final object CheckFreeSpace extends Check { | |||
|
|
|||
| def run: IOResult[HealthcheckResult] = { | |||
| val file = root / "proc" / "mounts" | |||
| val mountsContent = file.lines.map(x => x.split(" ")(1)).toList | |||
| val mountsContent = file.lines.filter(_(0) == '/').map(x => x.split(" ")(1)).toList | |||
There was a problem hiding this comment.
can you had a comment to explain? With a link to the bug for future reference ?
ElaadF
force-pushed
the
ust_18534/skip_non_standard_moint_fs_for_free_space_check
branch
from
39cf8fb
to
f8a64ac
Compare
|
Commit modified |
fanf
approved these changes
Nov 9, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18534