Fixes #18540: Healthcheck checks happen to often #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Nov 10, 2020
| ApplicationLogger.info("Property 'metrics.healthcheck.scheduler.period' is missing or empty in rudder.configFile. Default to 5mins.") | ||
| 5.minutes | ||
| ApplicationLogger.info("Property 'metrics.healthcheck.scheduler.period' is missing or empty in rudder.configFile. Default to 6 hours.") | ||
| 20.seconds |
| @@ -50,10 +50,10 @@ class HealthcheckNotificationService( | |||
| v <- Ref.make[List[HealthcheckResult]](List.empty) | |||
| } yield v).runNow | |||
|
|
|||
| private[this] def reloadCache(ref: Ref[List[HealthcheckResult]]): UIO[Unit] = { | |||
| def reloadCache(ref: Ref[List[HealthcheckResult]] = healthcheckCache): UIO[Unit] = { | |||
There was a problem hiding this comment.
why that change?
Default parameters are a code smell, they tend to bring a lot of complicated problem on the long term.
If you need a way to say "now, do init your internal things", it's better to have a dedicated init method. That way, it's also easier to understand you class state machine (entry points, transition, etc).
| @@ -536,6 +536,9 @@ class Boot extends Loggable { | |||
| } | |||
| } | |||
|
|
|||
| // Run a health check | |||
| RudderConfig.healthcheckNotificationService.reloadCache() | |||
There was a problem hiding this comment.
I would prefer a startService here.
There was a problem hiding this comment.
a duplicated healthcheckNotificationService used only at boot ?
There was a problem hiding this comment.
no, just the method: RudderConfig.healthcheckNotificationService.startService. Or start or init
fanf
approved these changes
Nov 10, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18540