Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18634: Add a script example for auto-acceptation of nodes by hook #3397

Merged
merged 1 commit into from Nov 20, 2020
Merged

Fixes #18634: Add a script example for auto-acceptation of nodes by hook #3397

merged 1 commit into from Nov 20, 2020

Conversation

fanf
Copy link
Member

@fanf fanf commented Nov 19, 2020

@fanf fanf requested a review from amousset November 19, 2020 19:59
ncharles
ncharles reviewed Nov 19, 2020
View reviewed changes
...er-core/src/main/resources/hooks.d/node-inventory-received-pending/auto-accept-nodes.example Outdated
# - RUDDER_NODE_POLICY_SERVER_ID: the node policy server id
# - RUDDER_NODE_OS_NAME: OS normalized name (Linux distribution, Windows with version, etc)
# - RUDDER_NODE_OS_VERSION: OS version
# - RUDDER_NODE_OS_SP: OS service pach
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: patch

@fanf
Copy link
Member Author

fanf commented Nov 19, 2020

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3397
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/32879/console)

@fanf
Copy link
Member Author

fanf commented Nov 20, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_18634/add_a_script_example_for_auto_acceptation_of_nodes_by_hook branch from 47c90a9 to a22ab54 Compare November 20, 2020 18:00
@fanf fanf merged commit a22ab54 into Normation:branches/rudder/6.2 Nov 20, 2020
@fanf fanf deleted the bug_18634/add_a_script_example_for_auto_acceptation_of_nodes_by_hook branch March 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles left review comments

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Trigger test
Projects
None yet
Milestone
No milestone
4 participants
@fanf @Normation-Quality-Assistant @ncharles @amousset