Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18645: Upgrading 6.2 nightly to 6.2 nightly with plugins fails #3405

Conversation

VinceMacBuche
Copy link
Member

@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/6.2' set up to track remote branch 'branches/rudder/6.2' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/6.2'.
Already up to date.
Already up to date.
[...]
+ '[' --merge = --relayd ']'
+ '[' --merge = --language ']'
+ '[' --merge = --scala ']'
+ webapp/sources/rudder/rudder-core/src/test/resources/hooks.d/test-hooks.sh
+ export PYTHONPATH=./relay/sources/rudder-pkg/lib/rudder-pkg/:./relay/sources/rudder-pkg/lib:
+ PYTHONPATH=./relay/sources/rudder-pkg/lib/rudder-pkg/:./relay/sources/rudder-pkg/lib:
+ xargs pylint -E --persistent=n --disable=C,R,import-error,no-member,no-name-in-module
+ find . '!' -name convertOpenLDAPSchema.py '!' -wholename '*jsondiff/*' -name '*.py'
No config file found, using default configuration

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder/pull/3405 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/32975/console)

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3405
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/32983/console)

@fanf
Copy link
Member

fanf commented Nov 23, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_18645/upgrading_6_2_nightly_to_6_2_nightly_with_plugins_fails branch from d7da9b5 to 861fee2 Compare November 23, 2020 19:46
@fanf fanf merged commit 861fee2 into Normation:branches/rudder/6.2 Nov 23, 2020
latestVersion = pkgs.getLatestCompatibleRelease().version
latest_packages = pkgs.getLatestCompatibleRelease()
if (latest_packages is None):
print("No newer %s compatible versions found for the plugin %s"%(mode, p))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this case breaks the comparision just below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants