Fixes #3946 : add a service to fetch nodes executions and use them for reporting #341
Conversation
|
|
||
| def findExecutionTimeByNode( | ||
| nodeId : NodeId | ||
| , beginDate: DateTime | ||
| , endDate : Option[DateTime] | ||
| ) : Seq[DateTime] = { | ||
| var query = "select distinct executiontimestamp from ruddersysevents where ruleId = 'hasPolicyServer-root' and component = 'common' and keyValue = 'EndRun' and nodeId = ? and executiontimestamp >= ?" | ||
| var query = "select distinct date from reportsexecution where and nodeId = ? and date >= ?" |
There was a problem hiding this comment.
" where and " is legit ?
In any case, perhaps the and is not necessary
… by minimizing the number of query to the database
| , x.endDate | ||
| ) | ||
| ) | ||
| }.toMap |
There was a problem hiding this comment.
Here, if a given ruleId happen several time in the expectedConfigurationReports sequence, you will loose information ( (1,1), (1,2) ).toMap => [(1 -> 2)] )
There was a problem hiding this comment.
but you can have it only once; there are no duplicate of rules
There was a problem hiding this comment.
As discussed by other mean, the pb is not in rules but in the argument type of the method (seq in place of set). And in fact, there is no real problem, it was more than the refactoring was mixing optimization and algo logic, and Nico found a clean way to refactor again to make the optimization part apparent (so that it is not lost in the futur).
|
I've updated the PR with your remarks |
…ry_for_execution_reports Fixes #3946 : add a service to fetch nodes executions and use them for reporting
Ust 3945/impl 3946/add repository for execution reports