Fixes #18682: Error code should be 404 and not 500 when a node is not found for details API #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… found for details API
VinceMacBuche
approved these changes
Nov 24, 2020
|
I guess it's almost the same case for all other API (Rules Directives ...) |
|
This PR is not mergeable to upper versions. |
|
Hum, you're right. It's just more visible on node (because people are more likely to ask for node by id). |
|
OK, merging this PR |
fanf
deleted the
bug_18682/error_code_should_be_404_and_not_500_when_a_node_is_not_found_for_details_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18682