New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18846: Agent run schedule problem #3496

Merged

Normation-Quality-Assistant merged 1 commit into Normation:branches/rudder/6.1 from fanf:bug_18846/agent_run_schedule_problem

Feb 3, 2021

Member

fanf commented Feb 3, 2021 •

edited

Loading

https://issues.rudder.io/issues/18846

The main problem was that there was two places where we mixed up start minutes / start hours / splay time after getting values from json.

Other part of the PR is removing dead code:

an Empty case that was never reachable (and so I changed it to a pure result);
call to getAgentRunInterval etc in PromiseGenerationService which were never use (we directly use agentRun)


          Fixes #18846: Agent run schedule problem

9d3e61b

fanf requested a review from VinceMacBuche

February 3, 2021 20:18

fanf added the Trigger test label

VinceMacBuche approved these changes

View reviewed changes

Contributor

Normation-Quality-Assistant commented Feb 3, 2021

OK, merging this PR

Normation-Quality-Assistant merged commit 9d3e61b into Normation:branches/rudder/6.1

fanf deleted the bug_18846/agent_run_schedule_problem branch

March 15, 2024 10:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment