Fixes #18930: Documentation API doesn't build anymore #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElaadF
commented
Feb 19, 2021
| @@ -15,10 +15,6 @@ post: | |||
| properties: | |||
| allowed_networks: | |||
| type: object | |||
| optional: | |||
There was a problem hiding this comment.
By default properties are optional
use required to specify the opposite
ElaadF
commented
Feb 19, 2021
| @@ -6,7 +6,7 @@ post: | |||
| operationId: purgeSoftware | |||
| responses: | |||
| "200": | |||
| description: | |||
| description: Purge Software | |||
There was a problem hiding this comment.
If you have a better description, I will take it 😄
amousset
approved these changes
Feb 19, 2021
ElaadF
force-pushed
the
bug_18930/documentation_api_doesn_t_build_anymore
branch
from
9ca304b
to
d47fdbc
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18930