Fixes #18926: nodes API with include managementTechnologyDetails leads to error 500 response

[fanf]

https://issues.rudder.io/issues/18926

[ncharles]

why do you need the extra case?

[fanf]

we use a syntax shortcut in methods accepting function as argument: you can create a partial function with the following syntax { case x => ... } and so use it directly as argument, what we regularly do for map and alike function - and in that case, we are careful to use a partial function which is actually total by not imposing restriction on the x:

myUserList.map { case User(name, age) => name.capitalize }

But that really syntax for partial function, so you can put as many guard as you want in the pattern, use as many pattern as you want, and even don't make it total (and be sad when the pattern match exception happens):

myUserList.map { 
  case User(name, age) if age > 17 => 
  case User(name, age) if age > 5  => 
// and pattern match exception when age <= 6, but YOLO!
}

So in our case, since I wanted to have a different logic for the two cases of Option:

ZIO.foreach(agentWithKeys) { 
  case (Some(agent), key) => ...
  case (None, key)        =>
}

But then, I needed to apply a fold on result, and I don't know of a syntax that allow to do that with several pattern match in the partial function syntact, so I reverted to the usual pattern match syntax and only one branch for the partial function:

ZIO.foreach(agentWithKeys) { case (opt, key) =>  //that's for the function arg of `foreach`
  (opt, key) match { // that's a standard pattern matching 
    case (Some(agent), key) => ...
    case (None, key)        =>
  }
}

And with the fold:

ZIO.foreach(agentWithKeys) { case (opt, key) =>  //that's for the function arg of `foreach`
  ((opt, key) match { // that's a standard pattern matching 
    case (Some(agent), key) => ...
    case (None, key)        =>
  }).fold(....)
}

[ncharles]

Thank you for the time spent for the superb explanation of why adding the extra case, i learnt something

[Normation-Quality-Assistant]

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3513
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/35763/console)

[fanf]

OK, merging this PR