Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18931: No skipped directives on Rule screen after parent ticket #3514

Conversation

fanf
Copy link
Member

@fanf fanf commented Feb 19, 2021

@fanf
Copy link
Member Author

fanf commented Feb 19, 2021

PR updated with a new commit

@fanf
Copy link
Member Author

fanf commented Feb 19, 2021

PR updated with a new commit

Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am very surprised the change is so small, i ould have thought the impact of this would have been greater
can you correct the comment and self merge?

@fanf
Copy link
Member Author

fanf commented Feb 20, 2021

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3514
-- Your faithful QA
Kant merge: "To be is to do."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/35759/console)

@fanf
Copy link
Member Author

fanf commented Feb 20, 2021

OK, squash merging this PR

@fanf fanf force-pushed the bug_18931/no_skipped_directives_on_rule_screen_after_parent_ticket branch from 684b257 to 87ef8ec Compare February 20, 2021 09:39
@fanf fanf merged commit 87ef8ec into Normation:branches/rudder/6.1 Feb 20, 2021
@fanf fanf deleted the bug_18931/no_skipped_directives_on_rule_screen_after_parent_ticket branch March 15, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants