Fixes #18999: when we install a plugin, if the dependency (package manager) is not met, it still tries to install it and fails #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
ncharles
force-pushed
the
bug_18999/when_we_install_a_plugin_if_the_dependency_package_manager_is_not_met_it_still_tries_to_install_it_and_fails
branch
from
38db85b
to
cc975b3
Compare
Fdall
requested changes
Mar 19, 2021
| @@ -307,7 +318,36 @@ def install_dependencies(metadata): | |||
| logger.warning("The binary " + executable + " was not found on the system, you must install it before installing " + metadata['name']) | |||
| return False | |||
| else: | |||
There was a problem hiding this comment.
You should add a case in the same way that the "binary" type was defined. I am pretty sure we want to have typed dependencies and so, an "apt" and a "rpm" type of dependencies..
|
PR updated with a new commit |
Fdall
approved these changes
Apr 12, 2021
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
…nager) is not met, it still tries to install it and fails
fanf
force-pushed
the
bug_18999/when_we_install_a_plugin_if_the_dependency_package_manager_is_not_met_it_still_tries_to_install_it_and_fails
branch
from
f2801a8
to
c99cd86
Compare
|
OK, merging this PR |
4 similar comments
|
OK, merging this PR |
|
OK, merging this PR |
|
OK, merging this PR |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18999