Fixes #19061: Use rudderc to compile technique from the editor instead of rudder logic #3553
Conversation
| @@ -330,9 +350,12 @@ class TechniqueWriter ( | |||
| } | |||
| } | |||
|
|
|||
| def techniquePath(technique : Technique) = s"techniques/${technique.category}/${technique.bundleName.value}/${technique.version.value}" | |||
There was a problem hiding this comment.
What happens with category if it's a sub category? Does is contains the full relative path?
Also, I think we are going to have problem by calling Technique both com.normation.rudder.ncf.Technique and com.normation.cfclerk.domain.Technique. Can we rename the first one EditorTechnique ? (or something letting us know that it's not the same).
| for { | ||
| _ <- ApplicationLoggerPure.info(s"An error occurred when compiling technique '${technique.name}' (id : '${technique.bundleName}') with rudderc, error details will be displayed below, falling back to old saving process") | ||
| _ <- ApplicationLoggerPure.error(s"Rudderc error when compiling technique '${technique.name}' (id : '${technique.bundleName}'): ${e.fullMsg}") | ||
| - <- writeAgentFiles (technique, methods, modId, committer) |
There was a problem hiding this comment.
Nice :)
Perhaps we should store these rudderc exception in dedicated, independendant log files, for ex in /var/log/rudder/rudderc/failures/YYYY-MM-dd-hhmmss-techniqueName.log with the context that lead to the error:
- json file
- if it exists,
cfdscfile - the error log
That would allow users to send us these reports (or even to get them automatically with the support script)
| case Left(error: Error) => ApplicationLogger.error(error.getMessage) | ||
| case Left(error: RudderError) => ApplicationLogger.error(error.msg) | ||
| case Right(_) => ApplicationLogger.info(s"rudder-lang tester successfully looped for technique ${technique.bundleName.value}") | ||
| def callRudderc(technique : Technique) = { |
There was a problem hiding this comment.
I believe that needs to be an independant service, with constructor argument:
- config path file
- rudderc binary path
- target base path
Else we won't be able to test properties on the outputs at all.
There was a problem hiding this comment.
Regarding testing, we will need to embed a rudderc at some point - but I wonder where is the limit between testing rudderc and testing integration of rudderc into rudder with the specific things for it.
There was a problem hiding this comment.
(we need at least to test the general output layout, path, etc)
…d of rudder logic
|
PR rebased |
VinceMacBuche
force-pushed
the
ust_19061/use_rudderc_to_compile_technique_from_the_editor_instead_of_rudder_logic
branch
from
0ae62fb
to
266b849
Compare
… instead of rudder logic Fixes #19061: Use rudderc to compile technique from the editor instead of rudder logic
|
PR updated with a new commit |
| @@ -74,7 +74,7 @@ import com.normation.rudder.ncf.MethodCall | |||
| import com.normation.rudder.ncf.ParameterId | |||
| import com.normation.rudder.ncf.MethodParameter | |||
| import com.normation.rudder.ncf.TechniqueParameter | |||
| import com.normation.rudder.ncf.{Technique => NcfTechnique} | |||
| import com.normation.rudder.ncf.{EditorTechnique => NcfTechnique} | |||
There was a problem hiding this comment.
you should use EditorTechnique everywhere here, not NcfTechnique
… editor instead of rudder logic Fixes #19061: Use rudderc to compile technique from the editor instead of rudder logic
|
PR updated with a new commit |
https://issues.rudder.io/issues/19061