Fixes #19160: Query type constructor broke scale out relay plugin #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Apr 16, 2021
| @@ -947,6 +947,14 @@ object ResultTransformation { | |||
| } | |||
| } | |||
|
|
|||
| object Query{ | |||
There was a problem hiding this comment.
Please add a comment "necessary for 6.2 binary compat, need to be removed in 7.0 to avoid ambiguities in constructor"
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
VinceMacBuche
force-pushed
the
bug_19160/query_type_constructor_broke_scale_out_relay_plugin
branch
from
265f1f1
to
caa9d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/19160