Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #19195: Add rudder-lang publication to Jenkinsfile #3604

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fixes #19195: Add rudder-lang publication to Jenkinsfile #3604

merged 1 commit into from
Apr 29, 2021

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from peckpeck April 28, 2021 21:59
@amousset amousset added Trigger test WIP Use that label for a Work In Progress PR that must not be merged yet and removed Trigger test labels Apr 28, 2021
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset force-pushed the arch_19195/add_rudder_lang_publication_to_jenkinsfile branch from 8f3754f to 9793a9d Compare April 29, 2021 09:18
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset
Copy link
Member Author

PR updated with a new commit

VinceMacBuche
VinceMacBuche reviewed Apr 29, 2021
View reviewed changes
rust.makefile
@@ -62,7 +62,7 @@ lint: version
# to be sure clippy is actually run
touch src/lib.rs
mkdir -p target
cargo clippy --message-format json --all-targets --examples --tests > target/cargo-clippy.json
cargo clippy --message-format json --all-targets --examples --tests -- --deny warnings > target/cargo-clippy.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first -- with nothing is wanted ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, to mean the end of clippy options (and the remaining stuff is passed to the compiler)

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/3604
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/38250/console)

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the arch_19195/add_rudder_lang_publication_to_jenkinsfile branch from 305da7d to 98d3f15 Compare April 29, 2021 10:38
@amousset amousset merged commit 98d3f15 into Normation:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinceMacBuche VinceMacBuche VinceMacBuche approved these changes

@peckpeck peckpeck Awaiting requested review from peckpeck

Assignees
No one assigned
Labels
qa: Can't merge Trigger test WIP Use that label for a Work In Progress PR that must not be merged yet
Projects
None yet
Milestone
No milestone
3 participants
@amousset @Normation-Quality-Assistant @VinceMacBuche